[PATCH] D121214: [clang-tidy][docs][NFC] Add alias cert-mem51-cpp to bugprone-shared-ptr-array-mismatch

Balázs Benics via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 9 06:41:46 PST 2022


steakhal added a comment.

What I wanted is to highlight the relationship between the `bugprone-shared-ptr-array-mismatch` check and the `cert-mem51` rule.
I thought these aliases are the _programmatic_ way of encoding this relationship, but I understand that it might be a false advertisement given that only 1 out of 9 cases are caught by the related check.

What do you recommend?
Drop the alias-related changes and preserve the note in the `bugprone-shared-ptr-array-mismatch.rst` stating this relationship with the cert rule?
If we do it like that, then this will be again NFC.

How shall I proceed?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121214/new/

https://reviews.llvm.org/D121214



More information about the cfe-commits mailing list