[PATCH] D120296: [Attr] Fix a btf_type_tag AST generation bug

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 9 05:59:12 PST 2022


erichkeane added a comment.

1 comment, otherwise LGTM.  I'd like @aaron.ballman to take a look once you've got the attribute transforming as well though.



================
Comment at: clang/lib/Sema/TreeTransform.h:6876
+
+  BTFTypeTagAttr *Attr = oldType->getAttr();
+  QualType result = TL.getType();
----------------
The attribute needs to be transformed as well.  This should basically be a 'no op', but we need to do so in case we end up using 'treetransform' for something like a 'clone a node' type thing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120296/new/

https://reviews.llvm.org/D120296



More information about the cfe-commits mailing list