[PATCH] D120824: [clang][ASTImporter] Fix a bug when importing CXXDefaultInitExpr.

Gabor Marton via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 9 04:50:39 PST 2022


martong added a comment.

In D120824#3369563 <https://reviews.llvm.org/D120824#3369563>, @balazske wrote:

> 



> I think that the problem may be related to the fact that the in-class initializer is not used by the code in the "To" AST (in //ctu-cxxdefaultinitexpr.cpp// the problem is with `QMultiHash::d` field). Probably the expression node in the field is set only if it is used by any `CXXDefaultInitExpr`, but the `hasInClassInitializer` value is set always if the code contains in-class initializer. I can try to make a unit test for this case ...

Thanks, that'd be great.

> ... (but the lit test is good to have because it is more complex and can reveal other problems).

I agree.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120824/new/

https://reviews.llvm.org/D120824



More information about the cfe-commits mailing list