[PATCH] D121233: [pseudo] Move pseudoparser from clang to clang-tools-extra

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.

Thank you for working on this! I have a few thoughts on the renaming, but otherwise strongly support the direction here.

> clang/lib/Tooling/Syntax/Pseudo/*           => clang-tools-extra/pseudo/lib/*

The usual naming conventions in clang-tools-extra is to use the tool name as the folder it goes in. Based on that, should the folders be `clang-tools-extra/clang-pseudo/` instead of `clang-tools-extra/pseudo/`?

> clang/include/clang/Tooling/Syntax/Pseudo/* => clang-tools-extra/pseudo/include/clang-pseudo/*
> clang/tools/clang/pseudo/*                  => clang-tools-extra/pseudo/tool/*
> clang/test/Syntax/*                         => clang-tools-extra/pseudo/test/*

The convention are for clang-tools-extra tests to live in `clang-tools-extra/test/<tool>` (clangd is using the style you propose here when it probably should have followed the existing conventions).

> clang/unittests/Tooling/Syntax/Pseudo/*     => clang-tools-extra/pseudo/unittests/*
> #include "clang/Tooling/Syntax/Pseudo/*"    => #include "clang-pseudo/*"
> namespace clang::syntax::pseudo             => namespace clang::pseudo
> check-clang                                 => check-clang-pseudo
> clangToolingSyntaxPseudo                    => clangPseudo




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121233/new/

https://reviews.llvm.org/D121233