[PATCH] D121271: [C++20] [Modules] Don't generate strong function of a partition in importing modules

Chuanqi Xu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 9 00:17:11 PST 2022


ChuanqiXu added a comment.

In D121271#3369276 <https://reviews.llvm.org/D121271#3369276>, @iains wrote:

> I think you need to extend the test case (and possibly the code) to handle an implementation partition as well, where the module is both interface and implementation.

Yeah, this is the intention of `partb` (maybe I took a typo).

---

Also, I found all the CodeGen tests patch would better to depend D118352 <https://reviews.llvm.org/D118352> otherwise @urnathan might need to rebase again or we need to unnecessary rebase.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121271/new/

https://reviews.llvm.org/D121271



More information about the cfe-commits mailing list