[PATCH] D120713: [clangd] Make dexp command line options sticky
Sam McCall via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 8 01:15:45 PST 2022
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thank you!
================
Comment at: clang-tools-extra/clangd/index/dex/dexp/Dexp.cpp:417
+
+ // Protect IndexLocation, ExecCommand and ProjectRoot from being reset.
+ IndexLocation.setValue(IndexLocation, true /* initial */);
----------------
nit: comment echoes the code, say why instead?
Preserve global options when flag parser is reset, so commands can use them.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120713/new/
https://reviews.llvm.org/D120713
More information about the cfe-commits
mailing list