[PATCH] D121063: [AST] Make the last element in the linked list null

Erich Keane via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 7 07:19:43 PST 2022


erichkeane added a comment.

I suspect this works because we never really treated this as a LL, just as a pair of iterators.  Two things:

1- Can you produce some situation where this is valuable to do?
2- Can you switch this over so that the NextInContextAndBits initializes to nullptr/0 so that this line isn't necessary?  I can't imagine we ever re-call this on a decl and have the answer be different.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121063/new/

https://reviews.llvm.org/D121063



More information about the cfe-commits mailing list