[PATCH] D121093: [Driver][AArch64] Split up aarch64-cpus.c test further

[Son Tuan Vu via Phabricator via cfe-commits]

tyb0807 marked an inline comment as done.
tyb0807 added inline comments.


================
Comment at: clang/test/Driver/aarch64-cpus.c:2
+// Check target CPUs are correctly passed.
+// TODO: The files should be split up by categories, e.g. by architecture versions, to avoid excessive test
 // times for large single test files.
----------------
simon_tatham wrote:
> Tiniest nit ever: what files is this comment talking about?
> 
> (In the previous version, it followed on from a previous comment that gave the name of the file containing other half of the tests in question. Now it doesn't, so the wording is no longer clear.)
This is for just in case we want to split up this file (aarch64-cpus.c) further, into smaller files such as aarch64-cortex-a53.c, aarch64-cortex-a57.c, etc. Do you think we still need to do this, or this file looks ok to you in its current state?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121093/new/

https://reviews.llvm.org/D121093