[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

Qiu Chaofan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 6 21:05:43 PST 2022


qiucf added inline comments.


================
Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-math.c:98
 // CHECK-NEXT:    store double [[D:%.*]], double* [[D_ADDR]], align 8
+// CHECK-COUNT-3:    load double, double* [[D_ADDR]], align 8
 // CHECK-NEXT:    [[TMP0:%.*]] = load double, double* [[D_ADDR]], align 8
----------------
shchenz wrote:
> If we improve the check lines to CHECK-COUNT, do we still need the original CHECKs?
Yes, otherwise we can't capture the right operands of `llvm.ppc.fnmsub.f64`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116015/new/

https://reviews.llvm.org/D116015



More information about the cfe-commits mailing list