[PATCH] D118352: [clang][ABI] New c++20 modules mangling scheme

Sun Mar 6 18:06:43 PST 2022

ChuanqiXu added a comment.

In D118352#3359626 <https://reviews.llvm.org/D118352#3359626>, @urnathan wrote:

> In D118352#3358864 <https://reviews.llvm.org/D118352#3358864>, @ChuanqiXu wrote:
>
>> If I don't misread the codes, it looks like `mangleModuleInitializer` is not called.
>
>
>
>> Now we could add test for partitions.
>
> Correct, it is not called as the global initializer pieces are not yet implemented.  Let's not hold up this patch for that nor remove piece that will become necessary at that point.

It's odd to see unused functions. I just worry about that other people might delete these functions as cleaning up (maybe there wouldn't be).

---

Although the general declarations in partitions wouldn't be mangled specially, I think it would be better to add test case to show that.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D118352/new/

https://reviews.llvm.org/D118352