[PATCH] D121061: [OpenMPIRBuilder] Allocate temporary at the correct block in a nested parallel

[Johannes Doerfert via Phabricator via cfe-commits]

jdoerfert accepted this revision.
jdoerfert added a comment.
This revision is now accepted and ready to land.

LG, two nits.



================
Comment at: llvm/include/llvm/Transforms/Utils/CodeExtractor.h:127
     /// extraction of blocks containing alloca instructions would be possible,
     /// however code extractor won't validate whether extraction is legal.
     CodeExtractor(ArrayRef<BasicBlock *> BBs, DominatorTree *DT = nullptr,
----------------
Nit: Mention the AllocationBlock here too.


================
Comment at: llvm/lib/Transforms/Utils/CodeExtractor.cpp:1194
+        StructArgTy, DL.getAllocaAddrSpace(), nullptr, "structArg",
+        AllocationBlock ? &AllocationBlock->front()
+                        : &codeReplacer->getParent()->front().front());
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121061/new/

https://reviews.llvm.org/D121061