[PATCH] D121045: [analyzer][NFC] Merge similar conditional paths

Shivam Rajput via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Mar 6 07:34:14 PST 2022


phyBrackets added a comment.

In D121045#3362373 <https://reviews.llvm.org/D121045#3362373>, @steakhal wrote:

> I would probably query the opcode only once and reuse it, but is also fine.
>
> Btw whats your intention making this change? Do you plan greater refactorings/cleanups?

Yeah, I think query the opcode once is a nice idea tho, let me do this in this patch only. And yeah I'm thinking of refactoring/cleanups where it needed and would love to make some big refactors. But I found this when I was looking into this issue (https://github.com/llvm/llvm-project/issues/53564 and needs to look at the deadstorechecker file.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D121045/new/

https://reviews.llvm.org/D121045



More information about the cfe-commits mailing list