[PATCH] D120931: [clang-format] Fix namespace format when the name is a macro expansion

Owen Pan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 4 14:00:34 PST 2022


owenpan added inline comments.


================
Comment at: clang/lib/Format/NamespaceEndCommentsFixer.cpp:59-60
+
+    // Use the string after `namespace` until `{` or `::` or `(` as a name
+    // candidate. If the name is empty, use the candicate.
+    std::string FirstNSName;
----------------
owenpan wrote:
> Move "as a name candidate" to between "`namespace`" and "until".
> Move "as a name candidate" to between "`namespace`" and "until".

Or move it to after "Use", i.e. "Use as a name candidate the string after ...".


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120931/new/

https://reviews.llvm.org/D120931



More information about the cfe-commits mailing list