[clang] 9c300c1 - [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Fri Mar 4 04:26:32 PST 2022


Can you explain this commit please? I had to revert it in
6afe0354048f350442708eff0875101fe6f2bf44 because it broke the Sphinx
bot, but this looks like an unintentional commit and I wanted to
double-check (I had fixed this exact issue in
d74a3a514cf64731ecd21e1453aa78af79a565f2 and your changes here undid
my fix which is why I thought this might be an unintentional commit).

~Aaron

On Fri, Mar 4, 2022 at 1:48 AM via cfe-commits
<cfe-commits at lists.llvm.org> wrote:
>
>
> Author: phyBrackets
> Date: 2022-03-04T12:17:58+05:30
> New Revision: 9c300c18a4eaf79eb7044744bbdb705764579220
>
> URL: https://github.com/llvm/llvm-project/commit/9c300c18a4eaf79eb7044744bbdb705764579220
> DIFF: https://github.com/llvm/llvm-project/commit/9c300c18a4eaf79eb7044744bbdb705764579220.diff
>
> LOG: [analyzer] Done some changes to detect Uninitialized read by the char array manipulation functions
>
> Few weeks back I was experimenting with reading the uninitialized values from src , which is actually a bug but the CSA seems to give up at that point . I was curious about that and I pinged @steakhal on the discord and according to him this seems to be a genuine issue and needs to be fix. So I goes with fixing this bug and thanks to @steakhal who help me creating this patch. This feature seems to break some tests but this was the genuine problem and the broken tests also needs to fix in certain manner. I add a test but yeah we need more tests,I'll try to add more tests.Thanks
>
> Reviewed By: steakhal, NoQ
>
> Differential Revision: https://reviews.llvm.org/D120489
>
> Added:
>
>
> Modified:
>     clang/docs/analyzer/checkers.rst
>
> Removed:
>
>
>
> ################################################################################
> diff  --git a/clang/docs/analyzer/checkers.rst b/clang/docs/analyzer/checkers.rst
> index bc42b80d166c7..a9ebe063c6c8b 100644
> --- a/clang/docs/analyzer/checkers.rst
> +++ b/clang/docs/analyzer/checkers.rst
> @@ -2650,7 +2650,6 @@ Limitations:
>
>     - Due to limitations of the memory modeling in the analyzer, one can likely
>       observe a lot of false-positive reports like this:
> -
>        .. code-block:: c
>
>          void false_positive() {
>
>
>
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list