[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

Thu Mar 3 21:41:05 PST 2022

ChuanqiXu marked an inline comment as done.
ChuanqiXu added a comment.

In D120874#3358870 <https://reviews.llvm.org/D120874#3358870>, @tschuett wrote:

> Stupid question: this works with Windows as well? And the `BTW` sounds odd. gcc also decided to use a dash as the separator.

It should work with Windows since Windows should allow '-' in filename. The test shows this, too.

================
Comment at: clang/lib/Lex/HeaderSearch.cpp:199
+      // The separator of C++20 modules partitions (':') is not good for file
+      // systems, here we choose '-' by default since it is not a valid
+      // character of C++ indentifiers. So we could avoid conflicts. BTW, '-' is
----------------
tschuett wrote:
> Or: here clang and gcc choose ...
Thanks. It is helpful for non-native speakers : )

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120874/new/

https://reviews.llvm.org/D120874