[PATCH] D120874: [C++20] [Modules] Use '-' as the separator of partitions when searching in filesystems

[Chuanqi Xu via Phabricator via cfe-commits]

ChuanqiXu added inline comments.


================
Comment at: clang/test/Modules/search-partitions.cppm:20
+//--- partition1.cpp
+export module A : Part1;
+
----------------
iains wrote:
> ChuanqiXu wrote:
> > @MyDeveloperDay hi, I remember the support for partitions in clang-format is done in https://reviews.llvm.org/D114151. I think I did something wrong. I format my code with the following command in the root directory of llvm project:
> > ```
> > git diff -U0 --no-color --relative HEAD^ | clang/tools/clang-format/clang-format-diff.py -p1 -i
> > ```
> > 
> > Would it use an out-dated clang-format? If yes, how should I use the proper one. Or if is it possible that the `.clang-format` files is not updated correctly?
> FWIW, I have been using `git clang-format .... ` with llvm-14 clang-format in my PATH and it seems to work OK there - but not for llvm <= 13 (on macOS 10.15).
> 
It works now. Thanks!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120874/new/

https://reviews.llvm.org/D120874