[PATCH] D120890: [clang][dataflow] Add a lattice to track source locations.

Thu Mar 3 09:21:15 PST 2022

xazax.hun accepted this revision.
xazax.hun added a comment.
Herald added a subscriber: rnkovacs.

In D120890#3357454 <https://reviews.llvm.org/D120890#3357454>, @ymandel wrote:

> In D120890#3357438 <https://reviews.llvm.org/D120890#3357438>, @xazax.hun wrote:
>
>> Is there anything special about `SourceLocation`s? I wonder whether we just want a templated `PowerSet` lattice and instantiate it with `SourceLocation`s.
>
> Not really. Just that we use this lattice in a bunch of analyses for "unsafe access", like `std::optional` and `absl::Statusor` and (eventually) pointers. So, it seems generally useful as is. I agree that we should have core powerset lattice, its just that doing so will require a little more design effort (similar to the map lattice I added).  Happy to add that as a FIXME (which we plan to start tacking with github issues soon!), if that sounds good to you.

Sounds good, thanks!

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120890/new/

https://reviews.llvm.org/D120890