[PATCH] D120723: [pseudo] Fix an out-of-bound error in LRTable::find.

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added a comment.
Herald added a subscriber: alextsao1999.

I'm seeing debug failures again on Windows after this.

  FAIL: Clang :: Syntax/lr-build-conflicts.test (14728 of 14729)
  ******************** TEST 'Clang :: Syntax/lr-build-conflicts.test' FAILED ********************
  Script:
  --
  : 'RUN: at line 5';   clang-pseudo -grammar F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test -print-graph | f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test --check-prefix=GRAPH
  : 'RUN: at line 30';   clang-pseudo -grammar F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test -print-table | f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test --check-prefix=TABLE
  --
  Exit Code: 2
  
  Command Output (stdout):
  --
  $ ":" "RUN: at line 5"
  $ "clang-pseudo" "-grammar" "F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test" "-print-graph"
  $ "f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe" "F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test" "--check-prefix=GRAPH"
  $ ":" "RUN: at line 30"
  $ "clang-pseudo" "-grammar" "F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test" "-print-table"
  note: command had no output on stdout or stderr
  error: command failed with exit status: 3221226505
  $ "f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe" "F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test" "--check-prefix=TABLE"
  # command stderr:
  FileCheck error: '<stdin>' is empty.
  FileCheck command line:  f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe F:\source\llvm-project\clang\test\Syntax\lr-build-conflicts.test --check-prefix=TABLE
  
  error: command failed with exit status: 2
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  FAIL: Clang :: Syntax/lr-build-basic.test (14729 of 14729)
  ******************** TEST 'Clang :: Syntax/lr-build-basic.test' FAILED ********************
  Script:
  --
  : 'RUN: at line 5';   clang-pseudo -grammar F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test -print-graph | f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test --check-prefix=GRAPH
  : 'RUN: at line 18';   clang-pseudo -grammar F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test -print-table | f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test --check-prefix=TABLE
  --
  Exit Code: 2
  
  Command Output (stdout):
  --
  $ ":" "RUN: at line 5"
  $ "clang-pseudo" "-grammar" "F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test" "-print-graph"
  $ "f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe" "F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test" "--check-prefix=GRAPH"
  $ ":" "RUN: at line 18"
  $ "clang-pseudo" "-grammar" "F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test" "-print-table"
  note: command had no output on stdout or stderr
  error: command failed with exit status: 3221226505
  $ "f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe" "F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test" "--check-prefix=TABLE"
  # command stderr:
  FileCheck error: '<stdin>' is empty.
  FileCheck command line:  f:\source\llvm-project\llvm\out\build\x64-debug\bin\filecheck.exe F:\source\llvm-project\clang\test\Syntax\lr-build-basic.test --check-prefix=TABLE
  
  error: command failed with exit status: 2
  
  --
  
  ********************
  Testing:  0.. 10.. 20.. 30.. 40.. 50.. 60.. 70.. 80.. 90..
  ********************
  Failed Tests (2):
    Clang :: Syntax/lr-build-basic.test
    Clang :: Syntax/lr-build-conflicts.test
  
  
  Testing Time: 336.94s
    Unsupported      :  1727
    Passed           : 12972
    Expectedly Failed:    28
    Failed           :     2

It looks to be another index out of bounds assert with the MSVC STL debug iterators. Can you fix or revert?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120723/new/

https://reviews.llvm.org/D120723