[PATCH] D120875: [Driver] Split up huge aarch64-cpus.c test.
Simon Tatham via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 3 01:28:24 PST 2022
simon_tatham added a comment.
> While splitting up the test file is not ideal [...]
Actually I'm not so sure. I'd almost rather go further, and split it up into lots of //much// smaller files, each with some kind of reasonable theme, like "all the basically v8.1-A stuff" or "all the v8M".
The advantage of that is that it sets an obvious pattern for the next developer to follow – they look at the existing tests, notice there are lots of separate files, and make a fresh one rather than extending an existing one. Doing it this way, all that will happen is that one of the -1 and -2 files gets too big again in a year or two's time :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120875/new/
https://reviews.llvm.org/D120875
More information about the cfe-commits
mailing list