[PATCH] D120639: [RISCV] Pass -mno-relax to assembler when -fno-integrated-as specified

[Kito Cheng via Phabricator via cfe-commits]

kito-cheng added inline comments.


================
Comment at: clang/test/Driver/riscv-gnutools.c:19
 
+// Check default when -mno-relax and -fno-integrated-as specified
+// RUN: %clang -target riscv32 --gcc-toolchain=%S/Inputs/basic_riscv32_tree -mno-relax -fno-integrated-as %s -### -c \
----------------
jrtc27 wrote:
> All of these tests are using -fno-integrated-as, calling it out specifically for this one is misleading
Yeah, the comment is kind of misleading, actually we didn't check *default* value for `-march` or `-mabi` like other two checks(`CHECK-RV32IMAC-ILP32`/`CHECK-RV32IMAFDC-ILP32D`).


Maybe like this?

```
// Check -mno-relax has passed when `-fno-integrated-as` specified
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120639/new/

https://reviews.llvm.org/D120639