[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement
Phoebe Wang via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Mar 2 17:48:53 PST 2022
pengfei added a comment.
Sorry, I missed this patch. I think this is a wrong fix. The `buf[9]` doesn't make sense to X86 registers. You can see GCC fails with it too. https://godbolt.org/z/vPcfoG714
I think we just need to do sema check for it to emit error gracefully. BTW, I have a patch D107141 <https://reviews.llvm.org/D107141> to fix structure issues. Welcomes for suggestions.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120596/new/
https://reviews.llvm.org/D120596
More information about the cfe-commits
mailing list