[PATCH] D112774: [RISCV] Support k-ext clang intrinsics

[Craig Topper via Phabricator via cfe-commits]

craig.topper added inline comments.
Herald added a project: All.


================
Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:75
+// Zbkb extension
+TARGET_BUILTIN(__builtin_riscv_brev8, "ZiZi", "nc", "zbkb")
+TARGET_BUILTIN(__builtin_riscv_zip, "ZiZi", "nc", "zbkb")
----------------
Shouldn't brev8 be using "LiLi"?


================
Comment at: clang/include/clang/Basic/BuiltinsRISCV.def:76
+TARGET_BUILTIN(__builtin_riscv_brev8, "ZiZi", "nc", "zbkb")
+TARGET_BUILTIN(__builtin_riscv_zip, "ZiZi", "nc", "zbkb")
+TARGET_BUILTIN(__builtin_riscv_unzip, "ZiZi", "nc", "zbkb")
----------------
Please add `_32` to the end of zip and unzip.


================
Comment at: clang/lib/Sema/SemaChecking.cpp:4092
+  case RISCV::BI__builtin_riscv_sm4ed:
+    return SemaBuiltinConstantArgRange(TheCall, 2, 0, 3);
   }
----------------
What about aes64ks1i's rnum?


================
Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv32-zbkb.c:13
+//
+int brev8(int rs1)
+{
----------------
This should be long not int


================
Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbkb.c:1
+
+// NOTE: Assertions have been autogenerated by utils/update_cc_test_checks.py
----------------
Extra blank line at the top of the file


================
Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbkb.c:9
+// RV64ZBKB-NEXT:    [[RS1_ADDR:%.*]] = alloca i32, align 4
+// RV64ZBKB-NEXT:    store i32 [[RS1:%.*]], i32* [[RS1_ADDR]], align 4
+// RV64ZBKB-NEXT:    [[TMP0:%.*]] = load i32, i32* [[RS1_ADDR]], align 4
----------------
These should be i64


================
Comment at: clang/test/CodeGen/RISCV/rvb-intrinsics/riscv64-zbkb.c:14
+//
+int brev8(int rs1)
+{
----------------
This should be `long` not `int`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112774/new/

https://reviews.llvm.org/D112774