[PATCH] D119147: [AIX][clang][driver] Check the command string to the linker for exportlist opts

Wed Mar 2 12:53:35 PST 2022

DiggerLin added inline comments.

================
Comment at: clang/test/Driver/aix-ld.c:609
+// Check powerpc-ibm-aix7.1.0.0, 32-bit. -shared (with exp option strings in other opt).
+// RUN: %clangxx -x c++ -no-canonical-prefixes %s 2>&1 -### \
+// RUN:        -resource-dir=%S/Inputs/resource_dir \
----------------
MaskRay wrote:
> DiggerLin wrote:
> > MaskRay wrote:
> > > If you don't test `clang` in CHECK lines, you can omit `-no-canonical-prefixes`
> > > 
> > > Consider switching to `.cpp` if you always use `-x c++`.
> > all the test in the aix-ld.c using "-no-canonical-prefixes", in order to keep the same style. I am prefer to keep as it now. and create a NFC patch  to clean the ""-no-canonical-prefixes" later.  And keep the file name as aix-ld.c , it maybe better to have another NFC to change the file name.
> See D119309
thanks

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D119147/new/

https://reviews.llvm.org/D119147