[PATCH] D120774: [clang-format] Handle builtins in constraint expression

[Björn Schäpers via Phabricator via cfe-commits]

HazardyKnusperkeks added inline comments.


================
Comment at: clang/unittests/Format/FormatTest.cpp:23747
+  verifyFormat("template <class T>\n"
+               "concept integral = __is_integral(T);");
+
----------------
curdeius wrote:
> curdeius wrote:
> > How about other kinds?
> > This doesn't seem to work for at least ARRAY_TYPE_TRAIT (e.g. `concept OneDimensionalArray = __array_rank(T) == 1;`  and EXPRESSION_TRAIT.
> > 
> > Is there a way to be more generic and treat all identifier-like entities like identifiers?
> I'd like to see a test for ALIASes as well, e.g. `__is_same_as`.
> How about other kinds?
> This doesn't seem to work for at least ARRAY_TYPE_TRAIT (e.g. `concept OneDimensionalArray = __array_rank(T) == 1;`  and EXPRESSION_TRAIT.

I was conservative, since I don't know what these kind of traits are. But sure can add.

> Is there a way to be more generic and treat all identifier-like entities like identifiers?
Not that I know of. There is no such function in `TokenKind.h`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120774/new/

https://reviews.llvm.org/D120774