[PATCH] D120596: [clang][CGStmt] fix crash on invalid asm statement

Fangrui Song via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 2 10:57:50 PST 2022


MaskRay added inline comments.


================
Comment at: clang/lib/CodeGen/CGStmt.cpp:2517
+        else if (OutputTy->isFloatingPointTy())
           Arg = Builder.CreateFPExt(Arg, OutputTy);
       }
----------------
Shall we keep the assert (in a new `else` branch) just in case there are other cases which cannot be handled?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120596/new/

https://reviews.llvm.org/D120596



More information about the cfe-commits mailing list