[PATCH] D120331: [clang-tidy][run-clang-tidy.py] Add --config-file=<string> option

[Jonas Toth via Phabricator via cfe-commits]

JonasToth accepted this revision.
JonasToth added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.

LGTM, but please adjust the naming nit to a better name.

do you have commit rights? Otherwise someone (e.g. me) could commit on your behalf, of course with a remark that its your contribution :)



================
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:228
                       'default')
-  parser.add_argument('-config', default=None,
+  group = parser.add_mutually_exclusive_group()
+  group.add_argument('-config', default=None,
----------------
nit: i think `config_group` or so would be better to show that its only config-related. This name is too generic i feel.


================
Comment at: clang-tools-extra/clang-tidy/tool/run-clang-tidy.py:236
                       'each source file in its parent directories.')
+  parser.add_argument('-config-file', default=None,
+                      help='Specify the path of .clang-tidy or custom config'
----------------
SAtacker wrote:
> JonasToth wrote:
> > please ensure that those option exclude each other. right now it could be used with both options which is a contradiction for `clang-tidy`
> Do you mean mutual exclusion? From the docs: https://docs.python.org/3/library/argparse.html#mutual-exclusion
Yes, thanks :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120331/new/

https://reviews.llvm.org/D120331