[PATCH] D120793: [NFC] [C++20] [Modules] Simplify ActOnModuleImport by merging Path and Parition

Iain Sandoe via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 1 23:59:58 PST 2022


iains accepted this revision.
iains added a comment.
This revision is now accepted and ready to land.

other than the two nits, LGTM



================
Comment at: clang/include/clang/Sema/Sema.h:2996-2997
   /// \param ImportLoc The location of the 'import' keyword.
   /// \param Path The module toplevel name as an access path.
-  /// \param Partition The module partition name as an access path.
+  /// \param IsPartition If we are dealing with partitions.
   DeclResult ActOnModuleImport(SourceLocation StartLoc,
----------------
maybe:
"If the name is for a partition."


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120793/new/

https://reviews.llvm.org/D120793



More information about the cfe-commits mailing list