[PATCH] D112349: [Verifier] Add verification logic for GlobalIFuncs

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added a comment.
Herald added a project: All.

In D112349#3330918 <https://reviews.llvm.org/D112349#3330918>, @pirama wrote:

> Unrelated to missing resolver definition, this change doesn't accommodate resolvers that take parameters.  (Curiously, this verification only fails with ThinLTO).

Drive-by comment, not sure if it's relevant: clang doesn't run the verifier (by default) when assertions are turned off. This logic is in the Clang driver; if you add `-###` or `-v` you'll see the `-cc1` has `-disable-llvm-verifier` listed  whenever assertions are off. I believe if it reads a bitcode file, the "read bitcode" logic will run the verifier anyway; this just disables the "run verifier after IRGen" logic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112349/new/

https://reviews.llvm.org/D112349