[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

Duncan P. N. Exon Smith via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 1 16:51:17 PST 2022


dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Herald added a project: All.

LGTM, with one test suggestion.



================
Comment at: clang/test/Modules/add-remove-irrelevant-module-map.m:36-38
+#if __has_include("d.h") // This should use 'd.modulemap' in order to determine that 'd.h'
+                         // doesn't exist for 'c' because of its '[no_undeclared_includes]'.
+#endif
----------------
Would it be useful to also add a `#error` or similar inside the `#if`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120464/new/

https://reviews.llvm.org/D120464



More information about the cfe-commits mailing list