[PATCH] D120474: [clang][deps] Remove '-fmodules-cache-path=' arguments

[Duncan P. N. Exon Smith via Phabricator via cfe-commits]

dexonsmith added inline comments.
Herald added a project: All.


================
Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningTool.cpp:36
+  llvm::erase_if(Args, [](const std::string &Arg) {
+    return Arg.find("-fmodules-cache-path=") == 0;
+  });
----------------
Is that the only one to remove? (asking because you dropped the FIXME, which suggested it might only be one example)

Also, could this just be an assertion, since `makeInvocationForModuleBuildWithoutPaths()` is already clearing things?
- In other words, why do you need this in two places?
- And if you do need it in both, does the test cover both, or should there be another test or RUN line for the other code path?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120474/new/

https://reviews.llvm.org/D120474