[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

[Konrad Wilhelm Kleine via Phabricator via cfe-commits]

kwk added a comment.

In D120398#3352436 <https://reviews.llvm.org/D120398#3352436>, @HazardyKnusperkeks wrote:

> 



> That being said, I don't care that much that we declare the enums with a type. But I care about consistency. Either land this, or revert D93758 <https://reviews.llvm.org/D93758>.

Consistency was more or less the only reason why I made this change in the first place and I didn't expect so many comments on a change that is almost identical to D93758 <https://reviews.llvm.org/D93758>. Sure I didn't have a good argument for or against it so far but... consistency... I'm glad this discussion came up anyways. Will look at each comment tomorrow.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120398/new/

https://reviews.llvm.org/D120398