[PATCH] D120398: [format] follow up: Use unsigned char as the base of all enums in FormatStyle

[MyDeveloperDay via Phabricator via cfe-commits]

MyDeveloperDay added a comment.

In my own area I gave FormatStyle a copy constructor and made it private, it hardly caused any issues, this isn't something that we tend copy about very much, we tend copy construct it only when we do getLLVMStyle() to make another style say like google style sure we'll do that a handful of times but I very much doubt it would make an impact.. can we measure?

I have no problems adding the base class if that's the LLVM coding style recommendation, otherwise I don't see it gives us anything.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120398/new/

https://reviews.llvm.org/D120398