[PATCH] D117887: [NVPTX] Expose float tys min, max, abs, neg as builtins
Artem Belevich via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Tue Mar 1 10:26:12 PST 2022
tra added a comment.
In D117887#3351257 <https://reviews.llvm.org/D117887#3351257>, @jchlanda wrote:
> @tra thank you for landing the patches, it seems that the clang part (builtin declarations and tests) have been dropped, only `llvm` dir changes made it through. Is there any way I could fix it (same goes for the other two patches in this stack)?
Somehow `arc export | git apply` didn't pick clang changes when I was transferring the patch from the phabricator. I'll re-fetch the patches and will land the missing pieces shortly.
I'm not sure how the you've submitted the patch to phabricator. In general, it works best when the patch is supplied as a gic commit diff, with the author metadata, etc.
Or via `arc diff`. See for the details. https://llvm.org/docs/Phabricator.html#phabricator-reviews
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117887/new/
https://reviews.llvm.org/D117887
More information about the cfe-commits
mailing list