[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

[Diana Picus via Phabricator via cfe-commits]

rovka added a comment.

I don't have any other comments, I'll let Eric take it from here :)



================
Comment at: flang/lib/Frontend/FrontendActions.cpp:509
+      TargetRegistry::lookupTarget(theTriple, error);
+  assert(theTarget && "Failed to create Target");
+
----------------
awarzynski wrote:
> rovka wrote:
> > Shouldn't this be a diagnostic? People could be trying to compile a random IR file with a triple that's not registered.
> Good point! However, I'm struggling to trigger this assert ATM and I don't want to issue a diagnostic if I can't test it.  This will change once `flang-new` can consume LLVM IR files (soon). In the meantime, let me add a `TODO`. Hopefully we won't forget to elevate this to a proper diagnostic when the time is right :)
TODO is fine for now, thanks.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120568/new/

https://reviews.llvm.org/D120568