[PATCH] D114903: [clang] Support array placement new in constant expressions

Mon Feb 28 06:48:19 PST 2022

erichkeane added a comment.

In D114903#3285144 <https://reviews.llvm.org/D114903#3285144>, @Quuxplusone wrote:

> I have no special knowledge of this. Seems like "it can't be that easy," but I don't know.

I agree with this.  I have a little knowledge of the constant evaluator, but not enough to know what is going on in this function.  Presumably the rest of the array case is handled below for the 'nothrow' array case, so maybe it _IS_ that easy?  But Richard implemented this back in 2019 without review or explanation here, so we won't have anything for context unless @rsmith can comment.

I'm tempted to try to get this into `main` "soon" so that this can hang out in ToT for a while before making it to clang-15.  I DO think that the suggestions that @Quuxplusone made for new tests is a really good idea (and frankly, I'd like to see this with better test coverage), but otherwise I'm tempted to approve.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114903/new/

https://reviews.llvm.org/D114903