[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`

[Alexey Bataev via Phabricator via cfe-commits]

ABataev added inline comments.


================
Comment at: clang/include/clang/AST/StmtOpenMP.h:2917-2920
   Create(const ASTContext &C, SourceLocation StartLoc, SourceLocation EndLoc,
          ArrayRef<OMPClause *> Clauses, Stmt *AssociatedStmt, Expr *X, Expr *V,
-         Expr *E, Expr *UE, Expr *D, Expr *Cond, bool IsXLHSInRHSPart,
-         bool IsPostfixUpdate);
+         Expr *R, Expr *E, Expr *UE, Expr *D, Expr *Cond, bool IsXLHSInRHSPart,
+         bool IsPostfixUpdate, bool IsFailOnly);
----------------
There are too many params already, better to gather them into a struct/class


================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6216
-      KindsEncountered.contains(OMPC_capture)) {
-    IsCompareCapture = true;
     Kind = OMPC_compare;
----------------
Can this be fixed in a separate patch?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120290/new/

https://reviews.llvm.org/D120290