[PATCH] D120568: [flang][driver] Add support for -S and implement -c/-emit-obj

Diana Picus via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 28 04:53:46 PST 2022


rovka added a comment.

I'm having trouble building this on Windows on Arm. I'm still investigating if it's a problem with the patch or just growing pains on the WoA side :) I'll try to get to the bottom of it as soon as I can.



================
Comment at: flang/lib/Frontend/FrontendActions.cpp:509
+      TargetRegistry::lookupTarget(theTriple, error);
+  assert(theTarget && "Failed to create Target");
+
----------------
Shouldn't this be a diagnostic? People could be trying to compile a random IR file with a triple that's not registered.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120568/new/

https://reviews.llvm.org/D120568



More information about the cfe-commits mailing list