[PATCH] D115715: [clang-tidy] Fix llvm-header-guard for Windows paths containing drive letter (e.g. C:).

Salman Javed via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Feb 28 00:32:14 PST 2022


salman-javed-nz added a comment.

Hi @curdeius, have you had the chance to look at this since the last round of comments? The only thing I think this module still needs for now (until a new generic header guard check is developed), is a check that there aren't consecutive underscores in the output.

If you're busy, I don't mind finishing off this patch. I'm looking for things to do. As the author of the previous commit, I should have caught this case back then.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115715/new/

https://reviews.llvm.org/D115715



More information about the cfe-commits mailing list