[PATCH] D120498: [AST] Test RecursiveASTVisitor's current traversal of templates.
Nathan Ridge via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Sun Feb 27 23:39:07 PST 2022
nridge added a comment.
will leave approval to hokein, but LGTM
================
Comment at: clang/include/clang/AST/RecursiveASTVisitor.h:172
- /// Return whether this visitor should recurse into
- /// template instantiations.
+ /// Return whether we should traverse of AST nodes that were created by
+ /// template instantiation, rather than by written code.
----------------
nit: stray "of"
================
Comment at: clang/unittests/Tooling/RecursiveASTVisitorTests/Templates.cpp:283
+ VisitClassTemplateSpecializationDecl
+ VisitFieldDecl
+TraverseClassTemplateSpecializationDecl
----------------
Is this a FIXME (body is traversed is an instantiation declaration)?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120498/new/
https://reviews.llvm.org/D120498
More information about the cfe-commits
mailing list