[PATCH] D120305: [Driver] Default CLANG_DEFAULT_PIE_ON_LINUX to ON

Fri Feb 25 23:32:22 PST 2022

MaskRay added a comment.

In D120305#3347109 <https://reviews.llvm.org/D120305#3347109>, @tstellar wrote:

> [...]
> The issue here has nothing to do with the technical merits of the patch or what the root cause of the problem is.  The policy for this project is that if you commit a patch that breaks someone's configuration (especially a buildbot), then it needs to be fixed quickly or reverted.  I get that this policy can be frustrating as a committer when you feel your patch is correct, and the real problem is elsewhere, but this is still the policy and it should be followed.

7 hours ago my https://github.com/llvm/llvm-zorg/commit/b6ddf02ce3a54da2df29e7e599b1838167e0e3ad was sufficient to fix the issue and was the suggested fix in my opinion.
Unfortunately nobody on the PowerPC side made the change effective in the build bot. Rather, I received such a heated message (https://reviews.llvm.org/D120305#3347058).
It was another to fix the redness (revert) but IMO not justified.

And I think I need to push back such request as otherwise the red bot is going to waste other contributors' time (see my previous links on "Success Rate").
OK, that took me our hour to reply as a non-native speaker, forgetting that I probably should try harder to fix the issue.

Anyway, I find that my previous disabling tests attempt was actually effective. 274ec425dcc3e3f637dd006c5e9ae33bd0e2e917 <https://reviews.llvm.org/rG274ec425dcc3e3f637dd006c5e9ae33bd0e2e917> should have appeased https://lab.llvm.org/buildbot/#/builders/57

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120305/new/

https://reviews.llvm.org/D120305