[PATCH] D116439: [clang-tidy] Fix `readability-const-return-type` for pure virtual function.

Aaron Ballman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 25 04:08:57 PST 2022


aaron.ballman accepted this revision.
aaron.ballman added a comment.
This revision is now accepted and ready to land.

LGTM aside from a nit; can you also add a release note about the fix to clang-tools-extra/docs/ReleaseNotes.rst?



================
Comment at: clang-tools-extra/clang-tidy/readability/ConstReturnTypeCheck.cpp:122
+    // Do not propose fixes for virtual function.
+    const auto *Method = llvm::dyn_cast<CXXMethodDecl>(Def);
+    if (Method && Method->isVirtual())
----------------



CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116439/new/

https://reviews.llvm.org/D116439



More information about the cfe-commits mailing list