[PATCH] D120334: [NFC][Lexer] Make Lexer::LangOpts const reference

Dawid Jurczak via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Feb 25 03:14:00 PST 2022


yurai007 added a comment.

Unfortunately after change there is lifetime issue in FormatTokenLexer because LangOpts received from getFormattingLangOpts has automatic storage duration and Lexer gets reference to it.
Fix issue and poke CI to make sure clang-tools-extra tests on CI are passing. For now it's only about making CI happy, I'm gonna check also if nice performance gains are preserved (I guess they should be).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120334/new/

https://reviews.llvm.org/D120334



More information about the cfe-commits mailing list