[PATCH] D120366: [CUDA][SPIRV] Assign global address space to CUDA kernel arguments

Justin Lebar via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 24 15:09:50 PST 2022


jlebar added a comment.

- What's different in this patch vs the previous one?
- *Disabled a hip test on Windows that's breaking on head.* Can you clarify: Is this test broken at HEAD, or does it break with your patch?

  If it's broken at HEAD, then it should be disabled in a separate patch.

  If it breaks with your patch, can you explain why it should be disabled rather than fixed?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120366/new/

https://reviews.llvm.org/D120366



More information about the cfe-commits mailing list