[PATCH] D120511: [clang-format] Allow to set token types final

Björn Schäpers via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 24 14:02:32 PST 2022


HazardyKnusperkeks added inline comments.


================
Comment at: clang/lib/Format/FormatToken.h:379
+  void setFinalizedType(TokenType T) {
+    Type = T;
+    TypeIsFinalized = true;
----------------
curdeius wrote:
> Maybe we should assert here and in `setType` that: `assert(!TypeIsFinalized);`?
In `setType` we could. Here we would have the same problem I fixed in D120512.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120511/new/

https://reviews.llvm.org/D120511



More information about the cfe-commits mailing list