[PATCH] D113743: [RFC][clang][DebugInfo] Allow function-local statics and types to be scoped within a lexical block

Thu Feb 24 11:00:09 PST 2022

krisb added a comment.

In D113743#3343481 <https://reviews.llvm.org/D113743#3343481>, @dblaikie wrote:

> In D113743#3177437 <https://reviews.llvm.org/D113743#3177437>, @krisb wrote:
>
>> In D113743#3175301 <https://reviews.llvm.org/D113743#3175301>, @dblaikie wrote:
>>
>>> Not super surprising that lldb might not be able to deal with DWARF in this shape - is LLDB support important to you/something you plan to work on for this DWARF? Otherwise we might need to opt-out of this functionality when tuning for LLDB, for instance. Unless LLDB-invested folks are interested in doing the integration work (& even then, maybe disabling it for LLDB tuning until that's fixed). @aprantl @JDevlieghere
>>
>> Thank you for the suggestion!
>> I implemented a small workaround that makes lldb behaves like if the types have subprogram scope (see https://reviews.llvm.org/D115277), not sure I'll be able to do something better any time soon.
>> So, if D115277 <https://reviews.llvm.org/D115277> isn't acceptable, and nobody volunteers to implement this properly, the only way to proceed is to turn this functionality off for lldb.
>
> Thanks for having a go at a fix/workaround here.
>
> I think we'll still need to hear from Apple folks (@aprantl @JDevlieghere @shafik ) - I'm not sure what their backwards compatibility (new clang-produced binaries being debugged with an old lldb) requirements are. If they need some backcompat there, then I guess they/we/you would still need to disable this DWARF fidelity improvement when tuning for lldb. Hopefully that can be avoided, but I don't know.

Thank you!

FYI. I'm going to split this patch into two: one for local statics and one for types and other. The part for static variables seems clean and safe so we can let it go once backend will be ready for it.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113743/new/

https://reviews.llvm.org/D113743