[PATCH] D120454: clang/www: Add links to tracking issues for C++20 features

Arthur O'Dwyer via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 24 07:12:19 PST 2022


Quuxplusone added inline comments.


================
Comment at: clang/www/cxx_status.html:106
+automatically fetch status information from the issue in the tracker. For Example:</p>
+<p><a class='autoupdate' href='https://github.com/llvm/llvm-project/issues/54006'>No</a>
+</p>
----------------
HTML nit: these attributes should use `"` instead of `'` (ooh, and ditto in the actual HTML on lines 961 etc.)


================
Comment at: clang/www/cxx_status.html:1308-1313
       <tr> <!-- from Prague -->
         <td><a href="https://wg21.link/p2082r1">P2082R1</a></td>
+      <td rowspan=1 class="none" align="center">
+        <a class='autoupdate' href='https://github.com/llvm/llvm-project/issues/54050'>No</a>
+      </td>
       </tr>
----------------
Have you eyeballed the new rendering of this table here? (I haven't.) The indentation on these HTML lines is wonky now; looks like lines 1308, 1309, and 1313 are overindented by 2 spaces?


================
Comment at: clang/www/cxx_status.html:1652
+ * in the link text field. e.g.
+ * <a class='autoupdate' href='https://github.com/llvm/llvm-project/issues/54006'>No</a>
+ *
----------------
`s/'/"/g`


================
Comment at: clang/www/cxx_status.html:1660-1664
+Array.from(document.getElementsByClassName("autoupdate")).forEach(element => {
+  if (element.innerHTML != "No")
+    return;
+  updateIssueCell(element);
+})
----------------
Does this need to be in a `document.onload` or `<script defer>` or something? (My JS is entirely cargo-cult programming. :))


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120454/new/

https://reviews.llvm.org/D120454



More information about the cfe-commits mailing list