[PATCH] D120254: [OpenCL] Align subgroup builtin guards

[Douglas Yung via Phabricator via cfe-commits]

dyung added a comment.

In D120254#3342570 <https://reviews.llvm.org/D120254#3342570>, @svenvh wrote:

> In D120254#3342551 <https://reviews.llvm.org/D120254#3342551>, @dyung wrote:
>
>> Hi, our internal release build bots are showing failures in two clang-tidy tests that I bisected back to your commit, clang-tidy/checkers/altera-id-dependent-backward-branch.cpp and clang-tidy/checkers/altera-single-work-item-barrier.cpp. After this change, both are exhibiting this error:
>>
>>   Error while processing /home/dyung/src/upstream/aa9c2d19d9b73589d72114d6e0a4fb4ce42b922b-linux/tools/clang/tools/extra/test/clang-tidy/checkers/Output/altera-single-work-item-barrier.cpp.tmp.cpp.
>>   error: enum type memory_scope not found; include the base header with -finclude-default-header [clang-diagnostic-error]
>>
>> Oddly, this only fails in a release configuration. Can you take a look?
>
> I'll try to reproduce the failure locally, but until I've done so perhaps you could try whether the following fixes one of the tests?  If so, then the other test will likely need a similar fix.
>
>   diff --git a/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp b/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
>   index a6dbab7b72fc..9bc1bbf173cc 100644
>   --- a/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
>   +++ b/clang-tools-extra/test/clang-tidy/checkers/altera-id-dependent-backward-branch.cpp
>   @@ -1,4 +1,4 @@
>   -// RUN: %check_clang_tidy %s altera-id-dependent-backward-branch %t -- -header-filter=.* "--" -cl-std=CL1.2 -c --include opencl-c.h
>   +// RUN: %check_clang_tidy %s altera-id-dependent-backward-branch %t -- -header-filter=.* "--" -cl-std=CL1.2 -c --include opencl-c.h --include opencl-c-base.h
>    
>    typedef struct ExampleStruct {
>      int IDDepField;

I just tried that patch and it doesn't seem to fix it unfortunately.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120254/new/

https://reviews.llvm.org/D120254