[PATCH] D120464: [clang][modules] Report module maps affecting `no_undeclared_includes` modules

Jan Svoboda via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Feb 24 01:40:53 PST 2022


jansvoboda11 created this revision.
jansvoboda11 added reviewers: ilyakuteev, Bigcheese, dexonsmith.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.

Since D106876 <https://reviews.llvm.org/D106876>, PCM files don't report module maps as input files unless they contributed to the compilation.

Reporting only module maps of (transitively) imported modules is not enough, though. For modules marked with `[no_undeclared_includes]`, other module maps affect the compilation by introducing anti-dependencies.

This patch makes sure such module maps are being reported as input files.

Depends on D120463 <https://reviews.llvm.org/D120463>.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D120464

Files:
  clang/include/clang/Basic/Module.h
  clang/lib/Basic/Module.cpp
  clang/lib/Serialization/ASTWriter.cpp
  clang/test/Modules/add-remove-irrelevant-module-map.m

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D120464.411042.patch
Type: text/x-patch
Size: 4761 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20220224/5d8c81f7/attachment-0001.bin>


More information about the cfe-commits mailing list