[PATCH] D120290: [Clang][OpenMP] Add the codegen support for `atomic compare capture`
Shilei Tian via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Wed Feb 23 18:07:33 PST 2022
tianshilei1992 marked an inline comment as done.
tianshilei1992 added inline comments.
================
Comment at: clang/lib/CodeGen/CGStmtOpenMP.cpp:6067
+ if (VPtr) {
+ VOpVal = {VPtr, VPtr->getType()->getPointerElementType(),
+ V->getType().isVolatileQualified(),
----------------
nikic wrote:
> Please avoid adding new calls to getPointerElementType(). See https://github.com/llvm/llvm-project/commit/b1863d82454b2905db8b492bea0ce8a260362645 for a way to avoid it in this context.
Got it. Thanks for the info.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D120290/new/
https://reviews.llvm.org/D120290
More information about the cfe-commits
mailing list