[PATCH] D120266: [clang][CodeGen] Avoid emitting ifuncs with undefined resolvers

Itay Bookstein via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Feb 23 13:12:41 PST 2022


ibookstein added a comment.

Yeah, that's what happens with this patch; Reference binds against an `llvm::Function` declaration, linker resolves it to the actual ifunc in another translation unit and therefore emits IFUNC relocation.

Thinking about it more, this is inelegant. I would have liked the reference against the `cpu_specific` to bind against a plain "FOO" function declaration and not "FOO.ifunc", and 'upgrade' it later once a cpu_dispatch is encountered.
To my understanding, this is actually the reason https://reviews.llvm.org/D67058 added the plain-name alias.

I'll try to see if I can rework that.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D120266/new/

https://reviews.llvm.org/D120266



More information about the cfe-commits mailing list